bhasudha commented on pull request #1944:
URL: https://github.com/apache/hudi/pull/1944#issuecomment-673107178


   > @bhasudha @bschell the MOR support in presto as well, works using the 
compile time dependency?
   > 
   > seems, then to make presto generally work with bootstrap, we need to 
rethink that for higher presto versions at-least. How's athena working now, 
with the bundle or the compile-time dependency?
   
   
   
   > > I am kind of torn. On one hand, this completes the bootstrap story and 
lets us stabilize things. Given the later versions of presto anyway take hudi 
as a compile depedency, I think it may be ok?
   > > cc @bhasudha does prestoDB depend on the bundle or the hoodie-hadoop-mr 
jars?
   > 
   > Yes this is a good question. Should we really depend on `hud-hadoop-mr` in 
presto or the `presto-bundle` ? The bundle gives us the advantages of shading 
the dependencies to avoid such conflicts. Without bundle we would have to do 
the shading in `hudi-hadoop-mr` which does not seem right.   
   
   There is no strong reason for why we would need to depend on 
`hudi-hadoop-mr` from Presto.  I guess at that time, we were not yet thinking 
about how other use case would be supported in Presto and the dependencies that 
come along. We could certainly depend on the bundle instead. From my 
interactions, the presto community does not recommend dropping jars into 
plugin. So if we could instead take compile time dependency on the 
`presto-bundle`, that could work for all situations here. 
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to