yihua commented on code in PR #11130:
URL: https://github.com/apache/hudi/pull/11130#discussion_r1586993646
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DefaultSource.scala:
##########
@@ -263,10 +262,10 @@ object DefaultSource {
Option(schema)
}
- val useNewParquetFileFormat =
parameters.getOrDefault(HoodieReaderConfig.FILE_GROUP_READER_ENABLED.key(),
+ val useNewParquetFileFormat =
parameters.asJava.getOrDefault(HoodieReaderConfig.FILE_GROUP_READER_ENABLED.key(),
HoodieReaderConfig.FILE_GROUP_READER_ENABLED.defaultValue().toString).toBoolean
&&
!metaClient.isMetadataTable && (globPaths == null ||
globPaths.isEmpty) &&
- !parameters.getOrDefault(SCHEMA_EVOLUTION_ENABLED.key(),
SCHEMA_EVOLUTION_ENABLED.defaultValue().toString).toBoolean &&
+ !parameters.asJava.getOrDefault(SCHEMA_EVOLUTION_ENABLED.key(),
SCHEMA_EVOLUTION_ENABLED.defaultValue().toString).toBoolean &&
Review Comment:
Yeah, I missed this one. Fixed now. Previously, the conversion to Java Map
was implicit (implicitly converting to Java Map without using `.asJava`); in
Scala 2.13 it has to be explicit (`.asJava` is required). There is no logic
change here but we should avoid conversion for getting the config value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
