yihua commented on code in PR #11124:
URL: https://github.com/apache/hudi/pull/11124#discussion_r1587094528
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -558,9 +558,6 @@ protected void runTableServicesInline(HoodieTable table,
HoodieCommitMetadata me
return;
}
- if (config.isMetadataTableEnabled()) {
Review Comment:
I remember there’s a reason to sync the FS view for MDT. Is this
unnecessary now?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -798,7 +795,11 @@ protected void archive(HoodieTable table) {
}
try {
final Timer.Context timerContext = metrics.getArchiveCtx();
- // We cannot have unbounded commit files. Archive commits if we have to
archive
+ // We cannot have unbounded commit files. Archive commits if we have to
archive.
+
+ // Reload table timeline to reflect the latest commits,
+ // there are some table services (for e.g, the cleaning) that executed
right before the archiving.
+ table.getMetaClient().reloadActiveTimeline();
Review Comment:
Is this going to archive more instants since the view is refreshed? Maybe
we can avoid the overhead if that’s the case, since the next write should get
the timeline refreshed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
