danny0405 commented on code in PR #11148:
URL: https://github.com/apache/hudi/pull/11148#discussion_r1590186936
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/SimpleConcurrentFileWritesConflictResolutionStrategy.java:
##########
@@ -68,6 +69,7 @@ public Stream<HoodieInstant>
getCandidateInstants(HoodieTableMetaClient metaClie
.getTimelineOfActions(CollectionUtils.createSet(REPLACE_COMMIT_ACTION,
COMPACTION_ACTION))
.findInstantsAfter(currentInstant.getTimestamp())
.filterInflightsAndRequested()
+ .filter(i -> (!i.getAction().equals(COMPACTION_ACTION)) ||
i.getState().equals(REQUESTED))
.getInstantsAsStream();
Review Comment:
I guess if the compaction does not really execute before, there is no need
to resolve the conflicts, because the log files would slice based on their
specific completion time. If there is no confclits for the same file group from
multiple writers, then we are good. @linliu-code , we can add some test cases
to illustrate this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
