danny0405 commented on code in PR #11137:
URL: https://github.com/apache/hudi/pull/11137#discussion_r1590550067


##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java:
##########
@@ -925,6 +925,37 @@ public void 
testMetadataTableCompactionWithPendingInstants() throws Exception {
     
assertEquals(HoodieInstantTimeGenerator.instantTimeMinusMillis(inflightInstant2,
 1L), tableMetadata.getLatestCompactionTime().get());
   }
 
+  @Test
+  public void testInitializeMetadataTableWithPendingInstant() throws Exception 
{
+    init(COPY_ON_WRITE, false);
+    initWriteConfigAndMetatableWriter(writeConfig, false);
+    doWriteOperation(testTable, metaClient.createNewInstantTime(), INSERT);
+    doWriteOperation(testTable, metaClient.createNewInstantTime(), INSERT);
+
+    // test multi-writer scenario. let's add 1,2,3,4 where 1,2,4 succeeded, 
but 3 is still inflight. so latest delta commit in MDT is 4, while 3 is still 
pending
+    // in DT and not seen by MDT yet. compaction should not trigger until 3 
goes to completion.

Review Comment:
   yeah, I can remove it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to