danny0405 commented on code in PR #11182:
URL: https://github.com/apache/hudi/pull/11182#discussion_r1596123340
##########
hudi-common/src/main/java/org/apache/hudi/common/conflict/detection/TimelineServerBasedDetectionStrategy.java:
##########
@@ -60,4 +60,6 @@ public abstract void startAsyncDetection(Long initialDelayMs,
Long periodMs, Str
String basePath, Long
maxAllowableHeartbeatIntervalInMs,
HoodieStorage storage, Object
markerHandler,
Set<HoodieInstant>
completedCommits);
+
+ public abstract void stop();
Review Comment:
Maybe we implement `Closable` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
