yihua commented on code in PR #10900:
URL: https://github.com/apache/hudi/pull/10900#discussion_r1597744597
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/config/HoodieIncrSourceConfig.java:
##########
@@ -101,4 +101,11 @@ public class HoodieIncrSourceConfig extends HoodieConfig {
.withAlternatives(DELTA_STREAMER_CONFIG_PREFIX +
"source.hoodieincr.partition.extractor.class")
.markAdvanced()
.withDocumentation("PartitionValueExtractor class to extract partition
fields from _hoodie_partition_path");
+
+ public static final ConfigProperty<String> HOODIE_SPARK_DATASOURCE_OPTIONS =
ConfigProperty
+ .key(STREAMER_CONFIG_PREFIX +
"source.hoodieincr.data.datasource.options")
+ .noDefaultValue()
+ .markAdvanced()
+ .withDocumentation("A comma separate list of options that can be passed
to the spark dataframe reader of a hudi table, "
+ + "eg:
hoodie.metadata.enable=true,hoodie.enable.data.skipping=true");
Review Comment:
We can keep the config in the `HoodieIncrSourceConfig` class since it
applies to the incremental source only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
