yihua commented on code in PR #11189:
URL: https://github.com/apache/hudi/pull/11189#discussion_r1597754130


##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/IncrementalTimelineSyncFileSystemView.java:
##########
@@ -269,7 +269,7 @@ private void updatePartitionWriteFileGroups(Map<String, 
List<HoodieWriteStat>> p
         LOG.info("Syncing partition (" + partition + ") of instant (" + 
instant + ")");
         List<StoragePathInfo> pathInfoList = entry.getValue().stream()
             .map(p -> new StoragePathInfo(
-                new StoragePath(String.format("%s/%s", 
metaClient.getBasePath(), p.getPath())),
+                new StoragePath(metaClient.getBasePathV2(), p.getPath()),

Review Comment:
   If p.getPath() has a slash as the prefix, there will be a behavior change.



##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/IncrementalTimelineSyncFileSystemView.java:
##########
@@ -269,7 +269,7 @@ private void updatePartitionWriteFileGroups(Map<String, 
List<HoodieWriteStat>> p
         LOG.info("Syncing partition (" + partition + ") of instant (" + 
instant + ")");
         List<StoragePathInfo> pathInfoList = entry.getValue().stream()
             .map(p -> new StoragePathInfo(
-                new StoragePath(String.format("%s/%s", 
metaClient.getBasePath(), p.getPath())),
+                new StoragePath(metaClient.getBasePathV2(), p.getPath()),

Review Comment:
   ```suggestion
                   new StoragePath(String.format("%s/%s", 
metaClient.getBasePath(), p.getPath())),
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to