yihua commented on code in PR #11192:
URL: https://github.com/apache/hudi/pull/11192#discussion_r1597760489
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieFileWriterFactory.java:
##########
@@ -43,39 +40,18 @@
public class HoodieFileWriterFactory {
- private static HoodieFileWriterFactory
getWriterFactory(HoodieRecord.HoodieRecordType recordType) {
Review Comment:
`HoodieFileReaderFactory` and `HoodieFileWriterFactory` contain such methods
that throw `UnsupportedOperationException`. Instead, such methods should be
abstract and the factory classes should also be made abstract or interface.
```
protected HoodieFileReader newParquetFileReader(StorageConfiguration<?>
conf, StoragePath path) {
throw new UnsupportedOperationException();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
