yihua commented on code in PR #11210:
URL: https://github.com/apache/hudi/pull/11210#discussion_r1599366211


##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieHFileDataBlock.java:
##########
@@ -74,11 +61,10 @@
  * base file format.
  */
 public class HoodieHFileDataBlock extends HoodieDataBlock {
+  public static final String HFILE_COMPRESSION_ALGO_PARAM_KEY = 
"hfile_compression_algo";

Review Comment:
   Fixed by using `HFILE_COMPRESSION_ALGORITHM_NAME.key()` directly.  Also, I 
directly pass the String value of the config down so the String value is 
directly converted to the corresponding `Compression.Algorithm`, like 
`ParquetUtils`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to