nsivabalan commented on code in PR #11153:
URL: https://github.com/apache/hudi/pull/11153#discussion_r1599453665
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -575,6 +598,40 @@ private Pair<Integer, HoodieData<HoodieRecord>>
initializeRecordIndexPartition()
return Pair.of(fileGroupCount, records);
}
+ private static HoodieData<HoodieRecord>
readRecordKeysFromFileSlices(HoodieEngineContext engineContext,
+
List<Pair<String, FileSlice>> partitionFileSlicePairs,
Review Comment:
yes. It will. Are you suggesting to use the same method for COW as well?
I am not sure of the perf implications.
I would say, we need to audit entire code/repo to understand the BaseFile
reader code paths and if it can replaced w/ FileSlice reader.
So that both COW and MOR has same way of reading data files.
Would prefer to keep it out of the scope of this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
