geserdugarov opened a new pull request, #11216:
URL: https://github.com/apache/hudi/pull/11216

   ### Change Logs
   
   This MR fixes issue https://github.com/apache/hudi/issues/11044.
   `hoodie.datasource.write.row.writer.enable` is `true` by default, and for 
`BULK_INSERT` operation there is a shortcut in 
`HoodieSparkSqlWriter.writeInternal()`, which leads to ignoring of 
`hoodie.combine.before.insert` parameter even it was set explicitly by user.
   Added corresponding unit test, and also checked that the issue is fixed when 
PySpark with linked `hudi-spark-bundle` jar is used. (Made separate public 
repository for issues quick check if anyone would like to reuse it: 
https://github.com/geserdugarov/test-hudi-issues/)
   Also, the mentioned shortcut should be revisited, created separate Jira task 
[HUDI-7757](https://issues.apache.org/jira/browse/HUDI-7757).
   
   ### Impact
   
   None
   
   ### Risk level (write none, low medium or high below)
   
   Low
   
   ### Documentation Update
   
   None
   
   ### Contributor's checklist
   
   - [x] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [x] Change Logs and Impact were stated clearly
   - [x] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to