This is an automated email from the ASF dual-hosted git repository. yihua pushed a commit to branch branch-0.x in repository https://gitbox.apache.org/repos/asf/hudi.git
commit 0f6bc8cbd58a143151834f8b39c10cd4fcbf05fb Author: Sivabalan Narayanan <[email protected]> AuthorDate: Tue Apr 23 21:19:50 2024 -0700 [HUDI-6386] Enable testArchivalWithMultiWriters back as they are passing (#9085) Co-authored-by: Balaji Varadarajan <[email protected]> --- .../org/apache/hudi/io/TestHoodieTimelineArchiver.java | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiver.java b/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiver.java index 034bcc8788a..1edef971097 100644 --- a/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiver.java +++ b/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/io/TestHoodieTimelineArchiver.java @@ -65,7 +65,6 @@ import org.apache.hudi.testutils.HoodieSparkClientTestHarness; import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.fs.FileSystem; import org.junit.jupiter.api.AfterEach; -import org.junit.jupiter.api.Disabled; import org.junit.jupiter.api.Test; import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.Arguments; @@ -689,17 +688,9 @@ public class TestHoodieTimelineArchiver extends HoodieSparkClientTestHarness { assertThrows(HoodieException.class, () -> metaClient.getArchivedTimeline().reload()); } - @Disabled("HUDI-6841") - public void testArchivalWithMultiWritersMDTDisabled() throws Exception { - testArchivalWithMultiWriters(false); - } - - @Disabled("HUDI-6386") - public void testArchivalWithMultiWriters() throws Exception { - testArchivalWithMultiWriters(true); - } - - private void testArchivalWithMultiWriters(boolean enableMetadata) throws Exception { + @ParameterizedTest + @ValueSource(booleans = {false, true}) + public void testArchivalWithMultiWriters(boolean enableMetadata) throws Exception { HoodieWriteConfig writeConfig = initTestTableAndGetWriteConfig(enableMetadata, 4, 5, 5, 2, HoodieTableType.COPY_ON_WRITE, false, 10, 209715200, HoodieFailedWritesCleaningPolicy.LAZY, WriteConcurrencyMode.OPTIMISTIC_CONCURRENCY_CONTROL);
