nsivabalan commented on a change in pull request #1976:
URL: https://github.com/apache/hudi/pull/1976#discussion_r472099722



##########
File path: hudi-spark/src/main/scala/org/apache/hudi/HoodieWriterUtils.scala
##########
@@ -20,8 +20,8 @@ package org.apache.hudi
 import org.apache.hudi.DataSourceWriteOptions._
 import org.apache.hudi.common.config.TypedProperties
 
-import scala.collection.JavaConversions._
-import scala.collection.JavaConverters._
+import scala.collection.JavaConversions.mapAsJavaMap

Review comment:
       In general we should have a practice of not adding ".*" or "._" unless 
more than 3 or 4 entities are imported from same package. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to