danny0405 commented on code in PR #11219:
URL: https://github.com/apache/hudi/pull/11219#discussion_r1602400778
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -2000,16 +2000,15 @@ public DirectoryInfo(String relativePath,
List<StoragePathInfo> pathInfos, Strin
// Pre-allocate with the maximum length possible
filenameToSizeMap = new HashMap<>(pathInfos.size());
+ // Presence of partition meta file implies this is a HUDI partition
+ isHoodiePartition = pathInfos.stream().anyMatch(status ->
status.getPath().getName().startsWith(HoodiePartitionMetadata.HOODIE_PARTITION_METAFILE_PREFIX));
Review Comment:
> I'm worried that changing the isDataFile may lead to some unintended side
effects
Should be okay if all the CI tests pass. Actually the `isDataFile` for base
file does not make sense because the invoker always needs to consider the
directory is a Hudi partition dir, let's fix it.
Another concern is iterate through all the files under one partition is
inefficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
