zhuanshenbsj1 commented on PR #11031:
URL: https://github.com/apache/hudi/pull/11031#issuecomment-2114303657

   > Thanks for the contribuiton, here is a patch for the fix: 
[7622.patch.zip](https://github.com/apache/hudi/files/15140670/7622.patch.zip)
   > 
   > It would be greate if you can help to add some UTs.
   
   Made some adjustments:
   1. Create a new utility-class called SanityCheckUtil for validation, and 
move the checkKeygenGenerator and checkPreCombineKey methods from StreamerUtil 
to this class.
   2. Instantiate the MetaClient operation is heavy, so the Hudi source 
constructor adds a metaclient parameter to avoid multiple initializations for 
metaclient.
   3. Merge source and sink validation into same function, differentiating them 
by checking if the metaclient is null.
   4. Source needs to validate whether the columns and recordkey are consistent 
with the metadata.
   5. All exception prints after validation should include the table name.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to