xuzifu666 commented on code in PR #11245:
URL: https://github.com/apache/hudi/pull/11245#discussion_r1602812933


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/HoodieTimelineArchiver.java:
##########
@@ -217,6 +217,10 @@ private List<HoodieInstant> getCommitInstantsToArchive() 
throws IOException {
           earliestInstantToRetainCandidates.add(
               
completedCommitsTimeline.findInstantsModifiedAfterByCompletionTime(latestCompactionTime.get()).firstInstant());
         }
+      } catch (UnsupportedOperationException unsupportedOperationException) {
+        // If tableMetadata is FileSystemBackedTableMetadata would throw 
UnsupportedOperationException, should skip it to
+        // confirm next operation success
+        LOG.warn("tableMetadata is FileSystemBackedTableMetadata and skip 
limiting archiving of instants.");

Review Comment:
   
![1715846706392.png](https://github.com/apache/hudi/assets/10645422/9fcc7240-3975-4397-8106-d4195871f384)
   refer:HoodieTableMetadata#create If the MDT is not initialized would 
fallback to FileSystemBackedTableMetadata,so need add a guard for it @danny0405 
 When mdt is not enable, but mdt dir exsist before would return 
FileSystemBackedTableMetadata



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to