codope commented on code in PR #11146:
URL: https://github.com/apache/hudi/pull/11146#discussion_r1610329349
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -437,9 +448,7 @@ private boolean initializeFromFilesystem(String
initializationTime, List<Metadat
HoodieData<HoodieRecord> records =
fileGroupCountAndRecordsPair.getValue();
bulkCommit(commitTimeForPartition, partitionType, records,
fileGroupCount);
metadataMetaClient.reloadActiveTimeline();
- String partitionPath = partitionType == FUNCTIONAL_INDEX
- ? dataWriteConfig.getFunctionalIndexConfig().getIndexName()
- : partitionType.getPartitionPath();
+ String partitionPath = (partitionType == FUNCTIONAL_INDEX ||
partitionType == SECONDARY_INDEX) ?
dataWriteConfig.getFunctionalIndexConfig().getIndexName() :
partitionType.getPartitionPath();
Review Comment:
Will have to supply indexing config to
`MetadataPartitionType#getPartitionPath` to do so beacuse unlike functional or
secondary index, all other indexes in metadata have same name as well as
partition path. Functional or secondary index name are defined by user and that
is why need to fetch them from functional index config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
