(hudi) branch master updated: [HUDI-7801] Directly pass down HoodieStorage instance instead of recreation (#11309)

[yihua]

This is an automated email from the ASF dual-hosted git repository.

yihua pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git


The following commit(s) were added to refs/heads/master by this push:
     new b1ebcb7b95b [HUDI-7801] Directly pass down HoodieStorage instance 
instead of recreation (#11309)
b1ebcb7b95b is described below

commit b1ebcb7b95b7e427678b247053ecf8e4b06a4db4
Author: Y Ethan Guo <ethan.guoyi...@gmail.com>
AuthorDate: Sat May 25 22:48:05 2024 -0700

    [HUDI-7801] Directly pass down HoodieStorage instance instead of recreation 
(#11309)
---
 .../org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java | 2 +-
 .../org/apache/hudi/common/table/log/BaseHoodieLogRecordReader.java     | 2 +-
 .../hudi/internal/schema/io/FileBasedInternalSchemaStorageManager.java  | 2 +-
 .../src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java       | 2 +-
 .../main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java   | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git 
a/hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java
 
b/hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java
index ef91c23a8b7..61ced5ec230 100644
--- 
a/hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java
+++ 
b/hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java
@@ -160,7 +160,7 @@ public abstract class AbstractHoodieLogRecordReader {
     this.latestInstantTime = latestInstantTime;
     this.hoodieTableMetaClient = hoodieTableMetaClientOption.orElseGet(
         () -> HoodieTableMetaClient.builder()
-            .setStorage(storage.newInstance(new StoragePath(basePath), 
storage.getConf().newInstance()))
+            .setStorage(storage)
             .setBasePath(basePath).build());
     // load class from the payload fully qualified class name
     HoodieTableConfig tableConfig = 
this.hoodieTableMetaClient.getTableConfig();
diff --git 
a/hudi-common/src/main/java/org/apache/hudi/common/table/log/BaseHoodieLogRecordReader.java
 
b/hudi-common/src/main/java/org/apache/hudi/common/table/log/BaseHoodieLogRecordReader.java
index c346139e281..30e659057ce 100644
--- 
a/hudi-common/src/main/java/org/apache/hudi/common/table/log/BaseHoodieLogRecordReader.java
+++ 
b/hudi-common/src/main/java/org/apache/hudi/common/table/log/BaseHoodieLogRecordReader.java
@@ -154,7 +154,7 @@ public abstract class BaseHoodieLogRecordReader<T> {
     this.readerSchema = readerSchema;
     this.latestInstantTime = latestInstantTime;
     this.hoodieTableMetaClient = HoodieTableMetaClient.builder()
-        .setStorage(storage.newInstance(new StoragePath(basePath), 
storage.getConf().newInstance()))
+        .setStorage(storage)
         .setBasePath(basePath).build();
     // load class from the payload fully qualified class name
     HoodieTableConfig tableConfig = 
this.hoodieTableMetaClient.getTableConfig();
diff --git 
a/hudi-common/src/main/java/org/apache/hudi/internal/schema/io/FileBasedInternalSchemaStorageManager.java
 
b/hudi-common/src/main/java/org/apache/hudi/internal/schema/io/FileBasedInternalSchemaStorageManager.java
index 373dad34d1f..345bd3d3511 100644
--- 
a/hudi-common/src/main/java/org/apache/hudi/internal/schema/io/FileBasedInternalSchemaStorageManager.java
+++ 
b/hudi-common/src/main/java/org/apache/hudi/internal/schema/io/FileBasedInternalSchemaStorageManager.java
@@ -75,7 +75,7 @@ public class FileBasedInternalSchemaStorageManager extends 
AbstractInternalSchem
     if (metaClient == null) {
       metaClient = HoodieTableMetaClient.builder()
           .setBasePath(baseSchemaPath.getParent().getParent().toString())
-          .setStorage(storage.newInstance(baseSchemaPath, 
storage.getConf().newInstance()))
+          .setStorage(storage)
           .setTimeGeneratorConfig(
               
HoodieTimeGeneratorConfig.defaultConfig(baseSchemaPath.getParent().getParent().toString()))
           .build();
diff --git 
a/hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java 
b/hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java
index 27723fdc14e..5c57e1b4d58 100644
--- a/hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java
+++ b/hudi-common/src/main/java/org/apache/hudi/metadata/BaseTableMetadata.java
@@ -85,7 +85,7 @@ public abstract class BaseTableMetadata extends 
AbstractHoodieTableMetadata {
     super(engineContext, storage, dataBasePath);
 
     this.dataMetaClient = HoodieTableMetaClient.builder()
-        .setStorage(storage.newInstance(new StoragePath(dataBasePath), 
storage.getConf().newInstance()))
+        .setStorage(storage)
         .setBasePath(dataBasePath)
         .build();
 
diff --git 
a/hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java
 
b/hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java
index 5f8a92e8824..7a3368927ae 100644
--- 
a/hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java
+++ 
b/hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java
@@ -130,7 +130,7 @@ public class HoodieBackedTableMetadata extends 
BaseTableMetadata {
     } else if (this.metadataMetaClient == null) {
       try {
         this.metadataMetaClient = HoodieTableMetaClient.builder()
-            .setStorage(storage.newInstance(new StoragePath(metadataBasePath), 
storage.getConf().newInstance()))
+            .setStorage(storage)
             .setBasePath(metadataBasePath)
             .build();
         this.metadataFileSystemView = getFileSystemView(metadataMetaClient);