codope commented on code in PR #11146:
URL: https://github.com/apache/hudi/pull/11146#discussion_r1616260176
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieFunctionalIndexDefinition.java:
##########
@@ -52,7 +55,7 @@ public HoodieFunctionalIndexDefinition(String indexName,
String indexType, Strin
Map<String, String> indexOptions) {
this.indexName = indexName;
this.indexType = indexType;
- this.indexFunction = indexFunction;
+ this.indexFunction = nonEmpty(indexFunction) ? indexFunction :
SPARK_IDENTITY;
Review Comment:
if someone creates func index without specificying the function then we pick
the identity function to be default. The identity function is like f(x) = x, so
it just builds the index over x. It is like iceberg's identity transform -
https://iceberg.apache.org/spec/#partition-transforms
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
