nsivabalan opened a new pull request, #11363: URL: https://github.com/apache/hudi/pull/11363
### Change Logs This patch is for branch-0-x. Master patch https://github.com/apache/hudi/pull/11343 We can't let clean action executor skip files to be deleted. Due to networking glitches, there are chances some files may not be cleaned up. As of now, clean action execution succeeds and is tracked as part of "failedDeleteFiles". But if files to be deleted does not exists or already cleaned up, we are good. but if file deletion fails due to some other exception, we can't go past the issue. It could cause data consistency issues once the commit of interest goes into archived timeline (specifically incase of replace commits). So, this patch fixes the flow, where in clean action executor will ensure all intended files will be deleted for sure. On any exception, clean execution will fail. Added tests to cover below scenario: 1. fs.delete returns true 2. fs.delete returns false. fs.exists returns false 3. fs.delete return false, fs.exists returns true (clean execution is expected to fail) 4. fs.delete throws FileNotFoundException 5. fs.delete throws Runtime exception (clean execution is expected to fail) ### Impact Robust clean action. ### Risk level (write none, low medium or high below) low ### Documentation Update _Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._ - _The config description must be updated if new configs are added or the default value of the configs are changed_ - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website._ ### Contributor's checklist - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute) - [ ] Change Logs and Impact were stated clearly - [ ] Adequate tests were added if applicable - [ ] CI passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
