yihua commented on code in PR #11385:
URL: https://github.com/apache/hudi/pull/11385#discussion_r1625298506


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/index/ScheduleIndexActionExecutor.java:
##########
@@ -150,8 +150,8 @@ private void validateBeforeScheduling() {
   private void abort(HoodieInstant indexInstant) {
     // delete metadata partition
     partitionIndexTypes.forEach(partitionType -> {
-      if (metadataPartitionExists(table.getMetaClient().getBasePath(), 
context, partitionType.getPartitionPath())) {
-        deleteMetadataPartition(table.getMetaClient().getBasePath(), context, 
partitionType.getPartitionPath());
+      if 
(metadataPartitionExists(table.getMetaClient().getBasePath().toString(), 
context, partitionType.getPartitionPath())) {

Review Comment:
   It would be great to get rid of most of the `toString()` calls.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to