jonvex commented on code in PR #10957:
URL: https://github.com/apache/hudi/pull/10957#discussion_r1630142047
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieBaseFileGroupRecordBuffer.java:
##########
@@ -285,8 +324,8 @@ protected Option<T> merge(Option<T> older, Map<String,
Object> olderInfoMap,
* 1. A set of pre-specified keys exists.
* 2. The key of the record is not contained in the set.
*/
- protected boolean shouldSkip(T record, String keyFieldName, boolean
isFullKey, Set<String> keys) {
- String recordKey = readerContext.getValue(record, readerSchema,
keyFieldName).toString();
+ protected boolean shouldSkip(T record, String keyFieldName, boolean
isFullKey, Set<String> keys, Schema dataBlockSchema) {
Review Comment:
yep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
