xushiyan commented on a change in pull request #1997:
URL: https://github.com/apache/hudi/pull/1997#discussion_r474145442
##########
File path:
hudi-client/src/test/java/org/apache/hudi/testutils/HoodieClientTestUtils.java
##########
@@ -289,27 +245,9 @@ public static String writeParquetFile(String basePath,
String partitionPath, Lis
createCommitTime);
}
- public static String createNewMarkerFile(String basePath, String
partitionPath, String instantTime)
- throws IOException {
- return createMarkerFile(basePath, partitionPath, instantTime);
- }
-
- public static String createMarkerFile(String basePath, String partitionPath,
String instantTime)
- throws IOException {
- return createMarkerFile(basePath, partitionPath, instantTime,
UUID.randomUUID().toString(), IOType.MERGE);
- }
-
- public static String createMarkerFile(String basePath, String partitionPath,
String instantTime, String fileID, IOType ioType)
- throws IOException {
- String folderPath = basePath + "/" + HoodieTableMetaClient.TEMPFOLDER_NAME
+ "/" + instantTime + "/" + partitionPath + "/";
- new File(folderPath).mkdirs();
- String markerFileName = String.format("%s_%s_%s%s%s.%s", fileID,
DEFAULT_WRITE_TOKEN, instantTime,
- HoodieFileFormat.PARQUET.getFileExtension(),
HoodieTableMetaClient.MARKER_EXTN, ioType);
- File f = new File(folderPath + markerFileName);
- f.createNewFile();
- return f.getAbsolutePath();
- }
-
+ /**
+ * TODO move to {@link FileCreateUtils}.
Review comment:
yea good candidate to be moved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
