jonvex commented on code in PR #11415:
URL: https://github.com/apache/hudi/pull/11415#discussion_r1632093807
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieBaseFileGroupRecordBuffer.java:
##########
@@ -319,60 +311,6 @@ protected Option<T> merge(Option<T> older, Map<String,
Object> olderInfoMap,
return Option.empty();
}
- /**
Review Comment:
Moved these out of the base record buffer. extractRecordPositions is
specific to position based buffer and shouldskip is only used there as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
