yihua commented on code in PR #9894:
URL: https://github.com/apache/hudi/pull/9894#discussion_r1632102563
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -242,6 +249,11 @@ public HoodieFileGroupReaderIterator<T>
getClosableIterator() {
return new HoodieFileGroupReaderIterator<>(this);
}
+ public static RecordMergeMode getRecordMergeMode(Properties props) {
+ String mergeMode = getStringWithAltKeys(props,
HoodieCommonConfig.RECORD_MERGE_MODE, true).toUpperCase();
Review Comment:
Sounds good. The record merge mode is required to dictate the merging
behavior in release 1.x, playing the same role as the payload class config in
the release 0.x. During table upgrade, we need to infer the record merge mode
based on the payload class so it's correctly set. HUDI-7847 to track the work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
