yihua commented on code in PR #11449:
URL: https://github.com/apache/hudi/pull/11449#discussion_r1638685103
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -92,7 +92,6 @@ public HoodieFileGroupReader(HoodieReaderContext<T>
readerContext,
Option<InternalSchema> internalSchemaOpt,
HoodieTableMetaClient hoodieTableMetaClient,
TypedProperties props,
- HoodieTableConfig tableConfig,
Review Comment:
Could you think about simplifying all the parameters? The goal should be
that given the file group ID and the query type with the reader context,
storage instance, and the minimal set of configs (maybe with meta client), the
file group reader should be able to figure out all necessary configs to fill in
for reading the records out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
