yihua commented on code in PR #11385:
URL: https://github.com/apache/hudi/pull/11385#discussion_r1638837492
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/HoodieLogFileCommand.java:
##########
@@ -95,7 +95,7 @@ storage, new StoragePath(logFilePathPattern)).stream()
new HashMap<>();
int numCorruptBlocks = 0;
int dummyInstantTimeCount = 0;
- String basePath =
HoodieCLI.getTableMetaClient().getBasePathV2().toString();
+ String basePath = HoodieCLI.basePath;
Review Comment:
Have you tested the changes locally with Hudi CLI so that after changing the
base path to a different table, the Hudi CLI works properly on the new table
(both the base path and meta client are updated)?
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -581,23 +572,27 @@ public void validateTableProperties(Properties
properties) {
*/
public static HoodieTableMetaClient
initTableAndGetMetaClient(StorageConfiguration<?> storageConf, String basePath,
Properties
props) throws IOException {
+ return initTableAndGetMetaClient(storageConf, new StoragePath(basePath),
props);
Review Comment:
A good follow-up would be removing any util methods taking `String` path and
passing `StoragePath` instance all the way down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
