nsivabalan commented on code in PR #11448:
URL: https://github.com/apache/hudi/pull/11448#discussion_r1638753499
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -256,6 +257,137 @@ public static RecordMergeMode
getRecordMergeMode(Properties props) {
return RecordMergeMode.valueOf(mergeMode);
}
+ public static Builder builder() {
+ return new Builder<>();
+ }
+
+ public static class Builder<T> {
+
+ HoodieReaderContext<T> readerContext;
+ HoodieStorage storage;
+ String tablePath;
+ String latestCommitTime;
+ FileSlice fileSlice;
+ Schema dataSchema;
+ Schema requestedSchema;
+ Option<InternalSchema> internalSchemaOpt;
+ HoodieTableMetaClient hoodieTableMetaClient;
+ TypedProperties props;
+ HoodieTableConfig tableConfig;
+ long start;
+ long length;
+ boolean shouldUseRecordPosition = false;
+ long maxMemorySizeInBytes;
+ String spillableMapBasePath;
+ ExternalSpillableMap.DiskMapType diskMapType;
+ boolean isBitCaskDiskMapCompressionEnabled;
Review Comment:
wow. too many args.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -256,6 +257,137 @@ public static RecordMergeMode
getRecordMergeMode(Properties props) {
return RecordMergeMode.valueOf(mergeMode);
}
+ public static Builder builder() {
+ return new Builder<>();
+ }
+
+ public static class Builder<T> {
+
+ HoodieReaderContext<T> readerContext;
Review Comment:
private ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
