danny0405 commented on code in PR #11444:
URL: https://github.com/apache/hudi/pull/11444#discussion_r1639096208


##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieReaderConfig.java:
##########
@@ -72,4 +72,10 @@ public class HoodieReaderConfig extends HoodieConfig {
       .markAdvanced()
       .sinceVersion("1.0.0")
       .withDocumentation("Whether to use positions in the block header for 
data blocks containing updates and delete blocks for merging.");
+
+  public static final ConfigProperty<Boolean> ENABLE_INTERNAL_SCHEMA_CACHE = 
ConfigProperty
+          .key("hoodie.schema.cache.enable")
+          .defaultValue(false)

Review Comment:
   > Do you want me to change the defaultValue of this config to true, or to 
remove this config property completely and use internal schema cache everywhere 
unconditionally
   
   I'm inclined we remove the option, and do the cache where ever if possible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to