VitoMakarevich commented on code in PR #11450:
URL: https://github.com/apache/hudi/pull/11450#discussion_r1639851878
##########
hudi-hadoop-common/src/main/java/org/apache/parquet/avro/HoodieAvroReadSupport.java:
##########
@@ -46,11 +46,7 @@ public HoodieAvroReadSupport() {
@Override
public ReadContext init(Configuration configuration, Map<String, String>
keyValueMetaData, MessageType fileSchema) {
boolean legacyMode = checkLegacyMode(fileSchema.getFields());
- // support non-legacy list
- if (!legacyMode &&
configuration.get(AvroWriteSupport.WRITE_OLD_LIST_STRUCTURE) == null) {
Review Comment:
This line has been extracted and now I'm forcefully applying configuration
even if something is set by the user, since if the user has
`AvroWriteSupport.WRITE_OLD_LIST_STRUCTURE=true`, then the case with rewriting
3 levels into 2 levels, read will return NULL, so at the end either fail/silent
data loss at the writing part - these are scenarios 5 and 6 from the test suite.
This is opposite use case as we faced initially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
