jonvex commented on code in PR #11455:
URL: https://github.com/apache/hudi/pull/11455#discussion_r1641422901
##########
hudi-common/src/test/java/org/apache/hudi/common/table/read/TestHoodieFileGroupReaderBase.java:
##########
@@ -276,6 +277,10 @@ private void
validateOutputFromFileGroupReader(StorageConfiguration<?> storageCo
props.setProperty("hoodie.payload.ordering.field", "timestamp");
props.setProperty(RECORD_MERGER_STRATEGY.key(),
RECORD_MERGER_STRATEGY.defaultValue());
props.setProperty(RECORD_MERGE_MODE.key(), recordMergeMode.name());
+ props.setProperty(HoodieMemoryConfig.MAX_MEMORY_FOR_MERGE.key(),
String.valueOf(HoodieMemoryConfig.MAX_MEMORY_FOR_MERGE.defaultValue()));
Review Comment:
@codope asked me to do this in his comments
https://github.com/apache/hudi/pull/11455#discussion_r1638968211
https://github.com/apache/hudi/pull/11455#discussion_r1638968494
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/TestHoodiePositionBasedFileGroupRecordBuffer.java:
##########
@@ -125,17 +126,17 @@ public void prepareBuffer(RecordMergeMode mergeMode)
throws Exception {
Option.empty(), metaClient.getTableConfig()));
TypedProperties props = new TypedProperties();
props.put(HoodieCommonConfig.RECORD_MERGE_MODE.key(), mergeMode.name());
+
props.setProperty(HoodieMemoryConfig.MAX_MEMORY_FOR_MERGE.key(),String.valueOf(HoodieMemoryConfig.MAX_MEMORY_FOR_MERGE.defaultValue()));
Review Comment:
@codope asked me to do this in his comments
https://github.com/apache/hudi/pull/11455#discussion_r1638968211
https://github.com/apache/hudi/pull/11455#discussion_r1638968494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
