yihua commented on code in PR #11443:
URL: https://github.com/apache/hudi/pull/11443#discussion_r1642004896
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstant.java:
##########
@@ -136,7 +136,10 @@ public HoodieInstant(StoragePathInfo pathInfo) {
state = State.COMPLETED;
}
}
- completionTime = timestamps.length > 1 ? timestamps[1] : null;
+ completionTime = timestamps.length > 1
+ ? timestamps[1]
+ // for backward compatibility with 0.x release.
+ : state == State.COMPLETED ? pathInfo.getModificationTime() + "" :
null;
Review Comment:
Could we print a warning message on such an instant to make sure the user is
aware of this since the modification time is not a robust as the completion
time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
