yanghua commented on a change in pull request #1920: URL: https://github.com/apache/hudi/pull/1920#discussion_r475094341
########## File path: hudi-spark/src/main/java/org/apache/hudi/keygen/parser/AbstractHoodieDateTimeParser.java ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.keygen.parser; + +import org.apache.hudi.common.config.TypedProperties; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.keygen.TimestampBasedKeyGenerator; +import org.joda.time.DateTimeZone; +import org.joda.time.format.DateTimeFormatter; + +import java.io.Serializable; +import java.util.TimeZone; + +public abstract class AbstractHoodieDateTimeParser implements Serializable { Review comment: I am not sure if it's a good design. You make a detailed implementation pull-up into an abstraction. Why? `getInputDateTimeZone` and `getOutputDateTimeZone ` should be abstract method and be pushed down to a sub-class like before. Moreover, you can see it contains if/else block, it is full of changes. The main benefit of abstract classes is to provide templates for the implementation of some subclasses. Instead of thinking that the default implementation is a template and marking it as an abstract class. So I think the original design is good. WDYT? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
