VitoMakarevich commented on PR #11450:
URL: https://github.com/apache/hudi/pull/11450#issuecomment-2175605541

   Also I see that this block
   ```
   if (!legacyMode) {
         requestedSchema = new MessageType(requestedSchema.getName(), 
convertLegacyMap(requestedSchema.getFields()));
       }
   ```
   is redundant - since in all the cases `requestedSchema` fetched after tuning 
AvroWriteSupport.WRITE_OLD_LIST_STRUCTURE equals to schema coming from this 
block - meaning AvroWriteSupport.WRITE_OLD_LIST_STRUCTURE does the correct 
conversion.
   So this code block should be removed to not cause confusion


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to