sreeram26 opened a new pull request #2014:
URL: https://github.com/apache/hudi/pull/2014


   
   
   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contributing.html before opening a 
pull request.*
   
   ## What is the purpose of the pull request
   
   Currently for Spark Streaming Write operation is being manually string 
compared on usage in most of the code, we also silently swallow illegal 
operation types by defaulting to upsert. This addresses these issues
   
   ## Brief change log
   
   - [HUDI-1153] Spark DataSource and Streaming Write must fail when operation 
type is misconfigured
   
   ## Verify this pull request
   
   This pull request is already covered by existing tests, such as *(please 
describe tests)*.
   TestDataSourceUtils
   * testDoWriteOperationWithoutUserDefinedBulkInsertPartitioner
   * testDoWriteOperationWithNonExistUserDefinedBulkInsertPartitioner
   * testDoWriteOperationWithUserDefinedBulkInsertPartitioner
   If all existing tests pass. This should be good to review
   
    - [ ] Existing tests pass 
   
   ## Committer checklist
   
    - [x] Has a corresponding JIRA in PR title & commit
    
    - [x] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [x] Necessary doc changes done or have another open PR - None
          
    - [x] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA- Not a large task


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to