voonhous opened a new pull request, #11577: URL: https://github.com/apache/hudi/pull/11577
### Change Logs Removing the case `INT` + **DATE** if - block as **DATE** types from the Hive related entrypoints will have a **DATE** `PrmitiveFieldObjectInspector` type.  From my understanding, this logic is mainly copied over from: https://github.com/apache/hudi/blob/70f44efe298771fcef9d029820a9b431e1ff165c/hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieRealtimeRecordReaderUtils.java#L178-L181 Of which, was introduced in this PR here: https://github.com/apache/hudi/pull/2634/files The `switch-case` for this is applied on a different entrypoint (switching an Avro Schema type). For such cases, **DATE** types will most definitely enter the `CASE-INT` block. However, in `HiveAvroSerializer`, the code is switching by `PrimitiveObjectInspector.PrimitiveCategory` instead. When reading **DATE** types, the `CASE-DATE` will be used instead of `CASE-INT`, making the block that we are deleting here a piece of code that will never be used. On top of that, the entire `CASE-INT` block can be removed as it is already handled by the `default` block Therefore, removing it to avoid further confusion. TLDR: Remove case-blocks as we are switching by different types and entrypoints are different ### Impact None ### Risk level (write none, low medium or high below) None ### Documentation Update _Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none"._ - _The config description must be updated if new configs are added or the default value of the configs are changed_ - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website._ ### Contributor's checklist - [X] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute) - [X] Change Logs and Impact were stated clearly - [ ] Adequate tests were added if applicable - [ ] CI passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
