beyond1920 commented on code in PR #11490:
URL: https://github.com/apache/hudi/pull/11490#discussion_r1668632752
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -1295,11 +1295,6 @@ public ExecutorType getExecutorType() {
return
ExecutorType.valueOf(getStringOrDefault(WRITE_EXECUTOR_TYPE).toUpperCase(Locale.ROOT));
}
- public boolean isCDCEnabled() {
- return getBooleanOrDefault(
- HoodieTableConfig.CDC_ENABLED,
HoodieTableConfig.CDC_ENABLED.defaultValue());
- }
-
Review Comment:
Should `CDC_ENABLED` be a table config or a write config?
Is there possible existed a table which does not enable cdc_enabled in table
config, but set it in the config of write job?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
