Davis-Zhang-Onehouse commented on code in PR #11265: URL: https://github.com/apache/hudi/pull/11265#discussion_r1668961091
########## hudi-common/src/test/resources/date-type-invalid.avsc: ########## Review Comment: Thanks Sagar for the comments, it might not be a good idea given: - Each small is small, all they added up is non trivial amount of code. If we have all those raw file content in the test code, it affects the readability. - We can add them into a separate test util, yet it is still in the form of "external dependency". The only benefits is reducing test runtime as we don't need to read from files. This is negligible benefits which I'm not sure it really worth extra dev efforts given other high priority task we are on. - In file format it's more readable. Java just does not tackle will to make huge raw string easy for human read. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
