voonhous commented on code in PR #11612:
URL: https://github.com/apache/hudi/pull/11612#discussion_r1674475818
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/shims/Hive3Shim.java:
##########
@@ -40,7 +40,8 @@ public class Hive3Shim implements HiveShim {
public static final String TIMESTAMP_WRITEABLE_V2_CLASS =
"org.apache.hadoop.hive.serde2.io.TimestampWritableV2";
public static final String DATE_WRITEABLE_V2_CLASS =
"org.apache.hadoop.hive.serde2.io.DateWritableV2";
- private static Class<?> TIMESTAMP_CLASS = null;
+ private static Class<?> TIMESTAMP_CLZZ = null;
Review Comment:
I was trying to standardise the usage of `CLASS` = string.
`CLZZ` = the Class instant
This is so as we will need to create a `TimestampWritableV2` Class variable
a few lines down too.
Since `TIMESTAMP_WRITEABLE_V2_CLASS` was used to define the string already,
i had to change it to `TIMESTAMP_WRITEABLE_V2_CLZZ` define its class.
Hence, the changes for the rest of the references to standardize the code
style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
