nsivabalan commented on code in PR #11562:
URL: https://github.com/apache/hudi/pull/11562#discussion_r1676775310
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstant.java:
##########
@@ -38,18 +39,22 @@
*/
public class HoodieInstant implements Serializable, Comparable<HoodieInstant> {
- // Instant like 20230104152218702.commit.request, 20230104152218702.inflight
+ // Instant like 20230104152218702.commit.request, 20230104152218702.inflight
and 20230104152218702_20230104152630238.commit
private static final Pattern NAME_FORMAT =
- Pattern.compile("^(\\d+)(\\.\\w+)(\\.\\D+)?$");
+ Pattern.compile("^(\\d+(_\\d+)?)(\\.\\w+)(\\.\\D+)?$");
private static final String DELIMITER = ".";
+ private static final String UNDERSCORE = "_";
+
private static final String FILE_NAME_FORMAT_ERROR =
"The provided file name %s does not conform to the required format";
+ private boolean completionTimeMissing = false;
Review Comment:
NTR:
this will help deduce the completed commit file name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
