KnightChess commented on code in PR #11569:
URL: https://github.com/apache/hudi/pull/11569#discussion_r1677271015


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieFileIndex.scala:
##########
@@ -284,8 +287,6 @@ case class HoodieFileIndex(spark: SparkSession,
         s"candidate file slices after data skipping: $candidateFileSliceSize; 
" +
         s"skipping percentage $skippingRatio")
 
-      hasPushedDownPartitionPredicates = true

Review Comment:
   I move it to line 231.



##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieFileIndex.scala:
##########
@@ -220,17 +220,20 @@ case class HoodieFileIndex(spark: SparkSession,
    *
    * @param dataFilters data columns filters
    * @param partitionFilters partition column filters
+   * @param partitionPrune for HoodiePruneFileSourcePartitions rule only prune 
partitions
    * @return A sequence of pruned partitions and corresponding filtered file 
slices
    */
-  def filterFileSlices(dataFilters: Seq[Expression], partitionFilters: 
Seq[Expression])
+  def filterFileSlices(dataFilters: Seq[Expression], partitionFilters: 
Seq[Expression], partitionPrune: Boolean = false)

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to