codope commented on code in PR #11631:
URL: https://github.com/apache/hudi/pull/11631#discussion_r1677482388
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/MetadataConversionUtils.java:
##########
@@ -255,9 +254,6 @@ public static <T extends SpecificRecordBase> T
convertCommitMetadata(HoodieCommi
}
hoodieCommitMetadata.getPartitionToWriteStats().remove(null);
org.apache.hudi.avro.model.HoodieCommitMetadata avroMetaData =
JsonUtils.getObjectMapper().convertValue(hoodieCommitMetadata,
org.apache.hudi.avro.model.HoodieCommitMetadata.class);
- if (hoodieCommitMetadata.getCompacted()) {
- avroMetaData.setOperationType(WriteOperationType.COMPACT.name());
- }
Review Comment:
I think we need this line. Completed `compaction` action is `commit` but in
the commit metadata file we set operation type as `COMPACT`. Then, during
conflict resolution when we read a `commit` file, we look for the write
operation type based on what is mentioned in the commit metadata file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
