prabodh1194 commented on code in PR #11628:
URL: https://github.com/apache/hudi/pull/11628#discussion_r1678187890
##########
packaging/hudi-cli-bundle/hudi-cli-with-bundle.sh:
##########
@@ -38,9 +38,15 @@ HUDI_CONF_DIR="${DIR}"/conf
HUDI_AUX_LIB="${DIR}"/auxlib
if [ ! -d $HUDI_AUX_LIB ]; then
- echo "Downloading necessary auxiliary jars for Hudi CLI"
- wget
https://repo1.maven.org/maven2/org/glassfish/jakarta.el/$JAKARTA_EL_VERSION/jakarta.el-$JAKARTA_EL_VERSION.jar
-P auxlib
- wget
https://repo1.maven.org/maven2/jakarta/el/jakarta.el-api/$JAKARTA_EL_VERSION/jakarta.el-api-$JAKARTA_EL_VERSION.jar
-P auxlib
+ echo "Downloading necessary auxiliary jars for Hudi CLI to $HUDI_AUX_LIB"
+ wget
https://repo1.maven.org/maven2/org/glassfish/jakarta.el/$JAKARTA_EL_VERSION/jakarta.el-$JAKARTA_EL_VERSION.jar
-P $HUDI_AUX_LIB
+ wget
https://repo1.maven.org/maven2/jakarta/el/jakarta.el-api/$JAKARTA_EL_VERSION/jakarta.el-api-$JAKARTA_EL_VERSION.jar
-P $HUDI_AUX_LIB
+
+ if [ "$IS_S3_ENABLED" = "true" ]; then
+ echo "Adding hadoop-aws jars to auxlib"
+ wget
https://repo1.maven.org/maven2/com/amazonaws/aws-java-sdk-bundle/1.12.262/aws-java-sdk-bundle-1.12.262.jar
-P $HUDI_AUX_LIB
+ wget
https://repo1.maven.org/maven2/org/apache/hadoop/hadoop-aws/3.3.4/hadoop-aws-3.3.4.jar
-P $HUDI_AUX_LIB
+ fi
Review Comment:
Agreed @CTTY . I tried with the `hudi-aws` bundle before creating the above
fix and that actually didn't work. `s3a` paths require
`org.apache.hadoop.fs.s3a.*` package which is defined in the `hadoop-aws`
module. `hudi-aws` modules only defines dependency on `hadoop-common`.
Hence, an explicit dependency is required in the `java` classpath.
Lemme know if I should explore this in some other manner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
