danny0405 commented on code in PR #11643:
URL: https://github.com/apache/hudi/pull/11643#discussion_r1681936827
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/ProvidesHoodieConfig.scala:
##########
@@ -384,7 +384,7 @@ trait ProvidesHoodieConfig extends Logging {
val staticPartitionValues = partitionSpec.filter(p =>
p._2.isDefined).mapValues(_.get)
val predicates = staticPartitionValues.map { case (k, v) =>
val partition = AttributeReference(k, partitionNameToType(k))()
- val value = Literal(v)
+ val value = HoodieSqlCommonUtils.castIfNeeded(Literal.create(v),
partitionNameToType(k))
EqualTo(partition, value)
Review Comment:
Great fix, can we add a UT test case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
