parisni commented on PR #11642:
URL: https://github.com/apache/hudi/pull/11642#issuecomment-2235912587

   > why do we need to check compatibility for type conversion here? 
   
   My idea is explained here 
https://github.com/apache/hudi/issues/11599#issuecomment-2233364178
   The current proposal is to fail to sync when hive does not support the 
promotion (while hudi does)
   
   > If the data has been successfully written, it indicates that Hudi supports 
it. Perhaps it's unnecessary to perform type conversion checks in this context. 
   
   Indeed, and there is no check for hudi. Only for hive here (metadata sync).
   
   > Regarding metadata synchronization, allowing the metadata engine to 
determine whether it supports type updates would be beneficial. 
   
   Do you mean, letting the metadata engine to fail at runtime if it does not 
support the operation ?
   
   That makes sense, let me change this PR accordingly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to