the-other-tim-brown commented on code in PR #11534:
URL: https://github.com/apache/hudi/pull/11534#discussion_r1685232920
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java:
##########
@@ -518,10 +515,10 @@ private Option<String>
getLastPendingCompactionInstant(Option<HoodieTimeline> co
/**
* Read from Upstream Source and apply transformation if needed.
*
- * @return Pair<InputBatch and Boolean> Input data read from upstream
source, and boolean is true if empty.
+ * @return Pair<InputBatch and Boolean> Input data read from upstream
source, and boolean is true if the result should use the row writer path.
* @throws Exception in case of any Exception
*/
- public InputBatch readFromSource(String instantTime, HoodieTableMetaClient
metaClient) throws IOException {
+ public Pair<InputBatch, Boolean> readFromSource(String instantTime,
HoodieTableMetaClient metaClient) throws IOException {
Review Comment:
@codope this is addressed, any other concerns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
