codope commented on code in PR #11678:
URL: https://github.com/apache/hudi/pull/11678#discussion_r1691360453
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestRecordLevelIndexWithSQL.scala:
##########
@@ -70,45 +77,45 @@ class TestRecordLevelIndexWithSQL extends
RecordLevelIndexTestBase {
assertEquals(5, spark.sql("select * from " + sqlTempTable).count())
// non existing entries in EqualTo query
- var dataFilter: Expression = EqualTo(attribute("_row_key"), Literal("xyz"))
+ var dataFilter: Expression = EqualTo(attribute(colName), Literal("xyz"))
assertEquals(0, spark.sql("select * from " + sqlTempTable + " where " +
dataFilter.sql).count())
assertEquals(0, fileIndex.listFiles(Seq.empty, Seq(dataFilter)).flatMap(s
=> s.files).size)
// non existing entries in IN query
- dataFilter = In(attribute("_row_key"), List.apply(Literal("xyz"),
Literal("abc")))
+ dataFilter = In(attribute(colName), List.apply(Literal("xyz"),
Literal("abc")))
Review Comment:
The test only enables RLI (apart from the file index by default). In
`verifyPruningFileCount` we assert the file count with both data skipping
enabled and disabled. In the case when skipping is enabled, we assert the
filtered file count obtained from file index is strictly less than that when
skipping is disabled. This could not have happened if RLI was not used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
