yihua commented on code in PR #11634:
URL: https://github.com/apache/hudi/pull/11634#discussion_r1692359991
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1097,7 +1096,7 @@ private HoodieData<HoodieRecord>
getFunctionalIndexUpdates(HoodieCommitMetadata
return getFunctionalIndexRecords(partitionFileSlicePairs, indexDefinition,
dataMetaClient, parallelism, readerSchema, storageConf);
}
- private void updateSecondaryIndexIfPresent(HoodieCommitMetadata
commitMetadata, Map<MetadataPartitionType, HoodieData<HoodieRecord>>
partitionToRecordMap, HoodieData<WriteStatus> writeStatus) {
+ private void updateSecondaryIndexIfPresent(HoodieCommitMetadata
commitMetadata, Map<String, HoodieData<HoodieRecord>> partitionToRecordMap,
HoodieData<WriteStatus> writeStatus) {
Review Comment:
Should we abstract these logic into a separate index class containing the
logic of updating index? It will be easier to maintain such logic and avoid
bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
