abyssnlp commented on code in PR #93:
URL: https://github.com/apache/hudi-rs/pull/93#discussion_r1692622588
##########
.github/workflows/ci.yml:
##########
@@ -22,9 +22,17 @@ on:
branches:
- main
- release/**
+ paths:
+ - 'python/**'
+ - '!python/Makefile'
+ - 'crates/**'
Review Comment:
Fair point. My reasoning was that as the project evolves, majority of the
changes would be within the `crates/` and `python/` paths. The trade-off here
would be between maintaining a list of paths to trigger the CI on vs.
maintaining the list of paths to ignore.
But if non-project dependencies won't change as much, I agree it would be
easier to just ignore those instead. I'll make the required changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
